Use fs/promises to reply immediately after a message is received

var -> const
Add standard for linting.

app.js

@@ -1,41 +1,39 @@
-var createError = require('http-errors');
+const createError = require('http-errors')
-var express = require('express');
+const express = require('express')
-var path = require('path');
+const path = require('path')
-var cookieParser = require('cookie-parser');
+const cookieParser = require('cookie-parser')
-var logger = require('morgan');
+const logger = require('morgan')
 
-var indexRouter = require('./routes/index');
+const indexRouter = require('./routes/index')
-var usersRouter = require('./routes/users');
 
-var app = express();
+const app = express()
 
 // view engine setup
-app.set('views', path.join(__dirname, 'views'));
+app.set('views', path.join(__dirname, 'views'))
-app.set('view engine', 'ejs');
+app.set('view engine', 'ejs')
 
-app.use(logger('dev'));
+app.use(logger('dev'))
-app.use(express.json());
+app.use(express.json())
-app.use(express.urlencoded({ extended: false }));
+app.use(express.urlencoded({ extended: false }))
-app.use(cookieParser());
+app.use(cookieParser())
-app.use(express.static(path.join(__dirname, 'public')));
+app.use(express.static(path.join(__dirname, 'public')))
 
-app.use('/', indexRouter);
+app.use('/', indexRouter)
-app.use('/users', usersRouter);
 
 // catch 404 and forward to error handler
-app.use(function(req, res, next) {
+app.use(function (req, res, next) {
-  next(createError(404));
+  next(createError(404))
-});
+})
 
 // error handler
-app.use(function(err, req, res, next) {
+app.use((err, req, res, next) => {
   // set locals, only providing error in development
-  res.locals.message = err.message;
+  res.locals.message = err.message
-  res.locals.error = req.app.get('env') === 'development' ? err : {};
+  res.locals.error = req.app.get('env') === 'development' ? err : {}
 
   // render the error page
-  res.status(err.status || 500);
+  res.status(err.status || 500)
-  res.render('error');
+  res.render('error')
-});
+})
 
-module.exports = app;
+module.exports = app

bin/www

@@ -3,23 +3,20 @@
 /**
  * Module dependencies.
  */
-
+const app = require('../app')
-var app = require('../app');
+const debug = require('debug')('message:server')
-var debug = require('debug')('message:server');
+const http = require('http')
-var http = require('http');
 
 /**
  * Get port from environment and store in Express.
  */
-
+const port = normalizePort('3010')
-var port = normalizePort('3010');
 app.set('port', port);
 
 /**
  * Create HTTP server.
  */
-
+const server = http.createServer(app)
-var server = http.createServer(app);
 
 /**
  * Listen on provided port, on all network interfaces.
@@ -34,7 +31,7 @@ server.on('listening', onListening);
  */
 
 function normalizePort(val) {
-  var port = parseInt(val, 10);
+  const port = parseInt(val, 10)
 
   if (isNaN(port)) {
     // named pipe
@@ -58,9 +55,9 @@ function onError(error) {
     throw error;
   }
 
-  var bind = typeof port === 'string'
+  const bind = typeof port === 'string'
     ? 'Pipe ' + port
-    : 'Port ' + port;
+    : 'Port ' + port
 
   // handle specific listen errors with friendly messages
   switch (error.code) {
@@ -82,9 +79,9 @@ function onError(error) {
  */
 
 function onListening() {
-  var addr = server.address();
+  const addr = server.address()
-  var bind = typeof addr === 'string'
+  const bind = typeof addr === 'string'
     ? 'pipe ' + addr
-    : 'port ' + addr.port;
+    : 'port ' + addr.port
   debug('Listening on ' + bind);
 }

package.json

@@ -3,7 +3,9 @@
   "version": "0.0.0",
   "private": true,
   "scripts": {
-    "start": "node ./bin/www"
+    "start": "node ./bin/www",
+    "lint": "standard",
+    "lint-fix": "standard --fix"
   },
   "dependencies": {
     "cookie-parser": "~1.4.4",
@@ -12,5 +14,8 @@
     "express": "~4.16.1",
     "http-errors": "~1.6.3",
     "morgan": "~1.9.1"
+  },
+  "devDependencies": {
+    "standard": "^17.1.0"
   }
 }

routes/index.js

@@ -1,23 +1,23 @@
-const express = require('express');
+const express = require('express')
-const router = express.Router();
+const router = express.Router()
-const fs = require('fs')
+const fs = require('fs/promises')
 
 const file = './messages'
 
 const get = (res, thankYou) => {
-  res.render('index', { title: 'Message Sage 😎', thankYou });
+  res.render('index', { title: 'Message Sage 😎', thankYou })
 }
 
 /* GET home page. */
-router.get('/', function(req, res, next) {
+router.get('/', function (req, res, next) {
   get(res, false)
-});
+})
 
 router.post('/', (req, res) => {
   const log = { message: req.body.message, timestamp: new Date() }
-  fs.appendFileSync(file, JSON.stringify(log) + '\n')
+  fs.appendFile(file, JSON.stringify(log) + '\n').catch(console.error)
 
   get(res, true)
 })
 
-module.exports = router;
+module.exports = router

routes/users.js

@@ -1,9 +0,0 @@
-var express = require('express');
-var router = express.Router();
-
-/* GET users listing. */
-router.get('/', function(req, res, next) {
-  res.send('respond with a resource');
-});
-
-module.exports = router;